Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata field rendering and log off-by-one error #51

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

kyle-sammons
Copy link
Collaborator

Summary

When initially converting from the Grafana DataFrame to a normal log object, we were being a bit lazy and just using the _source object. That resulted in us not having access to metadata fields (such as _id, _timesinceepoch, etc). This PR properly implements the DataFrame -> Log conversion giving us back access to the metadata fields.

Resolves: #50

We also were running into an issue that was caused by forgetting that the row index in the table and the index of the log we're rendering are going to be off by one due to the table header. This manifested as a search with one log not displaying anything.
Resolves: #49

Requirements (place an x in each [ ])

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

  • I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

src/pages/explore.tsx Outdated Show resolved Hide resolved
@kyle-sammons kyle-sammons merged commit dead011 into master Feb 13, 2024
2 checks passed
@kyle-sammons kyle-sammons deleted the ksammons-fix-metadata-field-rendering branch February 13, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata fields are not rendered in table results Error rendering table when only one result is returned
2 participants